Skip to content

feat: allow quickly scroll to top or bottom or PR page#8

Merged
Oreoxmt merged 2 commits into
Oreoxmt:mainfrom
ran-huang:feat/nav-top-bottom
Apr 4, 2023
Merged

feat: allow quickly scroll to top or bottom or PR page#8
Oreoxmt merged 2 commits into
Oreoxmt:mainfrom
ran-huang:feat/nav-top-bottom

Conversation

@ran-huang
Copy link
Copy Markdown
Contributor

  • Add 2 functions:
    • EnsureScrollToTopButton: scroll to top. Automatically hides itself when the page is already at the top.
    • EnsureScrollToBottomButton: scroll to bottom. Automatically hides itself when the page is already at the bottom.
  • Add if logic in the init function
    • calls the above 2 functions only on PR details page (https://github.com/*/pull/*)

image

Signed-off-by: Ran <huangran.alex@gmail.com>
@ran-huang
Copy link
Copy Markdown
Contributor Author

@Oreoxmt PTAL~

@Oreoxmt Oreoxmt merged commit 3a24613 into Oreoxmt:main Apr 4, 2023
@ran-huang ran-huang deleted the feat/nav-top-bottom branch April 4, 2023 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants