-
Notifications
You must be signed in to change notification settings - Fork 93
Reallocate by moving funds directly between vault and strategies #1071
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@shahthepro @DanielVF @franckc this is ready to be reviewed |
franckc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Took a pass. A few small nits inline otherwise looks great.
Please take a look at the fork tests failures - they seem relevant.
|
with the latest commit only 1 unrelated Morpho fork test is failing. |
|
@DanielVF a friendly ping |
|
Friendly ping @shahthepro @DanielVF for the review - not urgent at all but now that we have more strategies it would be nice to have that to save on gas and simplifies our weekly allocations. @sparrowDom as part of this PR, do we also need to update any tooling (like scripts) that we use for generating the allocation transactions? |
shahthepro
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, LGTM
4c412e3 to
e704bf6
Compare
|
Once we've used this in production for a few weeks, we'll probably want to remove the reallocate function. The gas savings is three transfers vs using deposit withdraw, but in the actual practice with our funds allocations, I don't think it would get used very often. Having two almost duplicate ways to do the same thing in the code isn't a good thing. We won't make a change for this in this PR though. |
…et been submitted. Update metastrategy address
DanielVF
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have reviewed these changes, and they are good.
withdrawFromStrategyanddepositToStrategyfunds allocation utility functionsIssue: #937
TODO (important):