Redo strategy allocation brownie helper code. #1202
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
DanielVF
commented
Dec 9, 2022
DanielVF
commented
- Much better brownie allocation helpers
- Removed old auto-allocations code that no longer works with the new strategies.
- Supports New vault value checker contract
- Strategist runlogs for Nov and Dec
New vault value checker Strategist runlogs
sparrowDom
reviewed
Dec 12, 2022
| else: | ||
| raise Exception('Could not look up strategy name "%s"' % strat_name) | ||
|
|
||
| if df["target_allocation"].sum() > 1.02: |
Member
There was a problem hiding this comment.
nit: 1.02 or 2% could be a constant somewhere on the top of a script. And same blow for 98%
sparrowDom
reviewed
Dec 12, 2022
sparrowDom
reviewed
Dec 12, 2022
sparrowDom
reviewed
Dec 12, 2022
sparrowDom
approved these changes
Dec 12, 2022
Member
sparrowDom
left a comment
sparrowDom
left a comment
There was a problem hiding this comment.
Left a couple of comments/questions ... otherwise LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.