Skip to content

Sparrow dom/deploy additions #1212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Jan 5, 2023
Merged

Sparrow dom/deploy additions #1212

merged 11 commits into from
Jan 5, 2023

Conversation

@sparrowDom
Copy link
Member

@sparrowDom sparrowDom commented Jan 4, 2023 •
edited
Loading

  • remove generalised strategies that we have no plans for deploying
  • exchange alUSD with LUSD in unit tests
  • make it easier to execute proposals that are in new/queued state and run fork tests on top of them:
    • if proposalId is present in deploy script and proposal exists in forked node queue and/or execute it and skip deployment
    • if proposalId is/Isn't present and forked node has lower block number (proposal doesn't exist on chain yet) execute deployment
    • if proposalId is present and proposal has already been executed on forked node skip deployment

@sparrowDom sparrowDom requested a review from shahthepro January 4, 2023 10:06
@sparrowDom
Copy link
Member Author

sparrowDom commented Jan 4, 2023

The one fork test failing is not relevant... I think this is good to merge CI wise

@sparrowDom sparrowDom mentioned this pull request Jan 4, 2023
Merged
5 tasks
franckc
franckc approved these changes Jan 5, 2023
View reviewed changes
Copy link

@franckc franckc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good cleanup and improvements! LGTM

@sparrowDom sparrowDom merged commit ef48ff8 into master Jan 5, 2023
@sparrowDom sparrowDom deleted the sparrowDom/deployAdditions branch January 5, 2023 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DanielVF DanielVF Awaiting requested review from DanielVF

@shahthepro shahthepro Awaiting requested review from shahthepro shahthepro is a code owner

1 more reviewer

@franckc franckc franckc approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sparrowDom @franckc