Skip to content

Conversation

@rolandpo
Copy link
Contributor

remove some analytics event tracking code + clean up some old marketing pages content

Copy link
Member

@sparrowDom sparrowDom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome job with the cleanup 👏
Curious why are we cleaning up some of the analytics tracking events? I haven't commented under each one that I though still might stay in the codebase

const metadata = swapMetadata()

try {
analytics.track('Before Swap Transaction', {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

curious why are we removing this one?

value = value > 50 ? 50 : value
value = truncateDecimals(value, 2)
if (value !== priceToleranceValue) {
analytics.track('On price tolerance change', {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also this one?

@rolandpo
Copy link
Contributor Author

rolandpo commented Apr 3, 2023

For the analytics tracking event I'm going off @jonathansnow's recommendations here https://docs.google.com/spreadsheets/d/1iWfCSBpxxAFu8yObAVKZCnlfk-d903RpgGCggT2Ex1A/edit#gid=0. I think for Before swap events, those are covered by the other swap events triggered on success/failure etc. In general though, I think the current analytics wrapper library might be retired eventually and whichever event tracking is still needed would be reimplemented in GTM directly, consistent with the rest of the codebases

@jonathansnow
Copy link
Contributor

Yes, what Roland mentioned above is true. We're migrating everything to GTM/GA4 and moving away from third-party libraries. UA EOL is on July 1st.

We've removed items we're not concerned about right now while noting them to be added back in the future possibly.

@micahalcorn micahalcorn merged commit d38b626 into master Apr 8, 2023
@micahalcorn micahalcorn deleted the rolandpo/events branch April 8, 2023 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants