OETH proxy #1269
Merged
OETH proxy #1269
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Typically for an important user facing contract, we'd give it its own proxy file, so that the contract shows at the top of the verification on Etherscan. However, we can do this. |
Contributor
See note below on ownership: |
Contributor
|
🛑 I think we want this owned by the OUSD 5/8 multisig with no timelock. This will speedup future setup of the protocol. The current transaction / proposal assigns ownership to the old governor. Otherwise, looks good. |
sparrowDom
force-pushed
the
sparrowDom/deploy-049
branch
from
d7665b6 to
5449f18
Compare
Member
Author
|
yup thanks for catching this @DanielVF. Have deployed a new version of both contracts with 5/8 being the pending governor |
DanielVF
approved these changes
Mar 30, 2023
Contributor
DanielVF
left a comment
DanielVF
left a comment
There was a problem hiding this comment.
- Deployed code matches
- Transactions match and are correct
- Simulation of governance action works and has intended effect.
Member
Author
|
thanks @DanielVF |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deploys the new OETH proxy with empty contract implementation
OETH Proxy:
0x856c4Efb76C1D1AE02e20CEB03A2A6a08b0b8dC3OETH empty implementation:
0x84E45FDD8AC0E1Ef13Da5F78037255009842d135