Update OUSD events and connect events. #1713
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathansnow
requested review from
rafaelugolini,
shahthepro,
smitch88 and
sparrowDom
as code owners
smitch88
reviewed
Jul 26, 2023
| localStorage.setItem('userConnectedWallet', 'true') | ||
| event({ | ||
| event: 'connect', | ||
| connect_address: address?.slice(2), |
Contributor
There was a problem hiding this comment.
Any reason to take off the 0x, does it look at is a hex number if you dont?
Contributor
Author
There was a problem hiding this comment.
Yeah, GA converts this into a number automatically 🥲
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking updates to bring OUSD/OETH into alignment. Added in new connect event to work with the new WalletConnect updates.