Skip to content

Refactor of Hardhat tasks #1716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 25, 2023
Merged

Refactor of Hardhat tasks #1716

merged 2 commits into from
Jul 25, 2023

Conversation

@naddison36
Copy link
Collaborator

@naddison36 naddison36 commented Jul 25, 2023

The main changes are:

  • using a signer factory so the signer can be from a private key, impersonated or Hardhat signer
  • Made the vault tasks work with either OUSD or OETH
  • Added generic token tasks. eg balance, allowance, approve, transfer, transferFrom
  • Added optional block param to view functions so historical values can be retrieved
  • Added tasks for the VaultValueChecker
  • Used subtasks so a task can be composed of multiple subtasks. eg rebase, snapshot, depositToStrategy and checkDelta

@naddison36 naddison36 added the contracts Works related to contracts label Jul 25, 2023
@naddison36 naddison36 self-assigned this Jul 25, 2023
@rafaelugolini rafaelugolini temporarily deployed to preview-oeth-nicka-hh-t-viwihq July 25, 2023 14:08 Inactive
@rafaelugolini rafaelugolini temporarily deployed to preview-ousd-nicka-hh-t-brplfj July 25, 2023 14:08 Inactive
@naddison36 naddison36 marked this pull request as draft July 25, 2023 14:10
@rafaelugolini rafaelugolini temporarily deployed to preview-ousd-nicka-hh-t-brplfj July 25, 2023 14:16 Inactive
@rafaelugolini rafaelugolini temporarily deployed to preview-oeth-nicka-hh-t-viwihq July 25, 2023 14:16 Inactive
@naddison36 naddison36 marked this pull request as ready for review July 25, 2023 14:23
@naddison36 naddison36 merged commit 16a45a6 into master Jul 25, 2023
@naddison36 naddison36 deleted the nicka/hh-tasks branch July 25, 2023 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sparrowDom sparrowDom Awaiting requested review from sparrowDom sparrowDom is a code owner

@shahthepro shahthepro Awaiting requested review from shahthepro shahthepro is a code owner

1 more reviewer

@DanielVF DanielVF DanielVF approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@naddison36 naddison36

Labels

contracts Works related to contracts

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@naddison36 @DanielVF @rafaelugolini