Enabled js lint for deploy scripts #1718
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
naddison36
commented
Jul 26, 2023
naddison36
commented
- Fix failing collateral swap fork test
naddison36
requested review from
DanielVF,
shahthepro and
sparrowDom
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1718 +/- ##
=======================================
Coverage 69.34% 69.34%
=======================================
Files 44 44
Lines 2349 2349
Branches 617 617
=======================================
Hits 1629 1629
Misses 717 717
Partials 3 3 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
shahthepro
approved these changes
Jul 31, 2023
|
|
||
| const dVaultCore = await deployWithConfirmation("VaultCore"); | ||
| const dVaultAdmin = await deployWithConfirmation("VaultAdmin"); | ||
| // const dVaultAdmin = await deployWithConfirmation("VaultAdmin"); |
Collaborator
There was a problem hiding this comment.
Are these intentionally commented out?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.