Abstract strategy gas improvements (#1719) #1724
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Refactor base strategy to use immutables * Fixed strategy deployments in 001_core and fixtures * Generated new strategy diagrams
naddison36
added
contracts
naddison36
requested review from
DanielVF,
shahthepro and
sparrowDom
as code owners
sparrowDom
reviewed
Jul 31, 2023
| /** | ||
| * @param _stratConfig The platform and OToken vault addresses | ||
| */ | ||
| constructor(BaseStrategyConfig memory _stratConfig) |
Member
There was a problem hiding this comment.
should all these constructor params be calldata instead of memory?
Collaborator
Author
There was a problem hiding this comment.
only storage or memory is supported for struct param.
Member
|
There look like ok changes to me on the other hand probably no need to rush it for the code freeze today? |
Member
|
Ah so we are only scoping today and not doing the actual code freeze. There are some fork tests failing other than that LGTM |
Collaborator
Author
|
The fork tests are failing as we have removed liquidity from the strategies. They should work again once we reenable the strategies. If not, I'll fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contract changes:
platformAddressandvaultAddressin theInitializableAbstractStrategychanged to be immutables.InitializableAbstractStrategyto preserve the storage slots.constructoradded to each of the strategy contracts to take theBaseStrategyConfigstruct that containsplatformAddressandvaultAddress.initializefunction on the strategy contract changed to not include theplatformAddressandvaultAddressparams.Contract change checklist: