Skip to content
This repository was archived by the owner on Jan 14, 2020. It is now read-only.

Simplify attestations #162

Merged
merged 3 commits into from
May 9, 2018
Merged

Simplify attestations #162

merged 3 commits into from
May 9, 2018

Conversation

@tyleryasaka
Copy link
Contributor

@tyleryasaka tyleryasaka commented May 8, 2018

Checklist:

  • Code contains relevant tests for the problem you are solving
  • Ensure all new and existing tests pass
  • Update any relevant READMEs and docs
  • Submit to the develop branch instead of master

Description:

  • Removes obsolete redirect-url param
  • Includes credentials in requests

Docs update: OriginProtocol/origin-docs-archived#24

tyleryasaka added 2 commits May 7, 2018 17:19
@tyleryasaka
Remove redirect url from requests
46c03a1 
The bridge server no longer accepts these params
@tyleryasaka
Include credentials in attestation requests
b5e203d 
This allows the bridge server sessions to function properly.
@tyleryasaka tyleryasaka requested a review from nick May 8, 2018 07:36
@joshfraser joshfraser merged commit 49fc45e into develop May 9, 2018
@tyleryasaka tyleryasaka deleted the tyleryasaka/simplify-attestations branch May 9, 2018 07:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@nick nick nick approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tyleryasaka @nick @joshfraser