Daily stats expansion #36
Conversation
| { | ||
| holders_over_threshold: number | ||
| }[] | ||
| >(holderStatsQuery) |
There was a problem hiding this comment.
Wouldn't mind centralizing these queries somewhere.
Perhaps with some sort of syntax like queries(ctx.store).ogvHolderStats()
Important factor being having all our one-off queries in a single place. I bring it up because I keep seeing new ones introduced.
| const holderStatsQuery = ` | ||
| SELECT COUNT(*) as holders_over_threshold | ||
| FROM ogv_address | ||
| WHERE balance > 100000000000000000000 |
There was a problem hiding this comment.
fyi think we can do WHERE balance > 1e17 which is cool
src/utils/coingecko.ts
Outdated
| export async function applyCoingeckoData( | ||
| ctx: Context, | ||
| props: { | ||
| Entity: any |
There was a problem hiding this comment.
nit: otoken processor shows how to do this, and yeah i know it's a pain in the rear
|
|
||
| const updatedStats = [] | ||
| let whereClause = { | ||
| timestamp: LessThanOrEqual(getStartOfDayTimestamp()), |
There was a problem hiding this comment.
alternatively dayjs.utc().startOf('day').toDate()
| } else { | ||
| const coingeckData = processCoingeckoData(coingeckoJson) | ||
| for (const dayId in coingeckData) { | ||
| const stat = statsWithNoPrice.find((s) => s.id === dayId) as |
There was a problem hiding this comment.
it's good that we cast it here since we define it as any above
apexearth
left a comment
apexearth
left a comment
There was a problem hiding this comment.
overall lgtm, left some comments
Uh oh!
There was an error while loading. Please reload this page.