Skip to content

Conversation

@apexearth
Copy link
Collaborator

  • Add investor wallet tracking
  • multichain erc20 processing
  • remove balancer, curve, maverick, liquidity source processing except for:
    • OUSD related curve pools
    • ETH/OETH curve Pool
  • fix rebase fk not found save bug
  • separate ousd deploy capability (just a manifest)
  • simplify some imports
  • some reorganization
  • new arbitrum processor
  • processing wOETH as an erc20 on mainnet and arbitrum
  • enhance ccip processing so we have both the outgoing tx and incoming tx, as well as the state on the BridgeTransfer object
  • move most of shared into mainnet
  • work on blockFrequencyTracker
    • want to have it's lowest frequency be once per minute.
    • more seems overkill and fills up the db rather quickly
    • though after removing some things that may be less of an issue

@apexearth apexearth requested a review from toniocodo April 19, 2024 03:06
])
erc20 = new ERC20({
id: address,
id: `${ctx.chain.id}-${address}`,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what do you think of adopting the same id format than in FE:
${symbol}${chainId === mainnet.id ? '' : `:${chainId}`}
Maybe wrap this in getTokenId/parseTokenId utils

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For using symbol, I'm unsure - address feels more official, yet we should only ever be officially recognizing specific symbols so it could be OK.

Regarding placement of the chainId, I would rather have it in front because it's the larger scale item.

Synchronizing these would be nice though I agree.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, I'm not against switching place for chain and address, this is how gnosis safe is doing as well... For the symbol vs address point, it's just to optimize readability, it's easier with the symbol obviously

  - created schema-otoken.graphql to be the future home of a joined otoken schema across chains
- txHash on `BridgeTransferState`
@apexearth apexearth merged commit 4cb8268 into main Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants