Restructuring, rebaseOpt In/Out, Financial Statement #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- start working on the financial statement - implement etl for the vault
apexearth
changed the title
…tement records remove txHash since it is inaccurate - multiple txs exist per block - we're storing by timestamp/block
switch some floats to bigint apy was using some incorrect date calculations perf to run everything is around ~25-30 minutes on my wifi
rafaelugolini
approved these changes
Sep 26, 2023
Contributor
|
@shahthepro can you take a look at it? You can check the graphql endpoint here: https://squid.subsquid.io/origin-squid/v/v6/graphql |
Contributor
Yeah, started looking at it yesterday, so far looks good to me, will approve once I'm done with a few tests in a bit :) |
shahthepro
reviewed
Sep 26, 2023
shahthepro
approved these changes
Sep 26, 2023
Contributor
shahthepro
left a comment
shahthepro
left a comment
There was a problem hiding this comment.
One question about Vault's ETH holding assumptions. Other than that, looks good to me
…to represent the 'Token Supply' liability which i forgot
Collaborator
Author
|
I'm going to remove the FinancialStatement object entirely and create it in the view instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.