Skip to content

Conversation

@apexearth
Copy link
Collaborator

@apexearth apexearth commented Aug 23, 2024

may merge this soon and deploy so I can set up some monitoring without having to follow-up later updating datasources

post-merge task:

  • create alert on WOETHPriceUpdated

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this is for dev only, probably doesn't need to be committed, even though I don't know how you usually proceed when you merge to main

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

import { Currency } from '@shared/post-processors/exchange-rates/currencies'

export const getBasePrice = async (ctx: Context, height: number, base: Currency, quote: Currency) => {
return undefined
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WIP probably

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, not yet sure we even need any rates like this there yet

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how to say something simple with many words

@apexearth apexearth merged commit a44a506 into main Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants