Feat/arm #58
Merged
Feat/arm #58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toniocodo
approved these changes
Oct 14, 2024
Collaborator
toniocodo
left a comment
toniocodo
left a comment
There was a problem hiding this comment.
couple of questions, nothing really blocking
| setup?: (p: ReturnType<typeof createSquidProcessor>, chain: Chain) => void | ||
| process: (ctx: Context) => Promise<void> | ||
| } | ||
| export const createProcessor = (p: Processor) => p |
Collaborator
There was a problem hiding this comment.
same than previous gql helper, why those identity functions?
Collaborator
Author
There was a problem hiding this comment.
I often find myself writing processors and having to remind myself what the schema is. if I just call this function it helps me to know. Otherwise you could do const armProcessor: Processor = { /* yada yada */ }
Why this over that? Good question I guess.
- add wethBalance to schema
- update dripper abi - add base harvester processing for YieldSent events (changes not active yet until some questions are answered)
- start loading vaultBuffer value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.