add endpoint for oeth subscriptions and add source column the email_l… #659
Conversation
migrations/versions/17de7a1bad16_.py
Outdated
|
|
||
| def upgrade(): | ||
| # ### commands auto generated by Alembic - please adjust! ### | ||
| # op.drop_table('bitcoin_prices') |
There was a problem hiding this comment.
Can we remove these commented out lines from the migration?
migrations/versions/17de7a1bad16_.py
Outdated
|
|
||
| def downgrade(): | ||
| # ### commands auto generated by Alembic - please adjust! ### | ||
| op.create_index('ix_token_info_created_at', 'token_info', ['created_at'], unique=False) |
There was a problem hiding this comment.
If these are commented out during the upgrade, let's not "undo" them during downgrade
|
|
||
| @cross_origin() | ||
| @app.route("/oeth-subscribe", methods=["POST"], strict_slashes=False) | ||
| def oeth_subscribe(): |
There was a problem hiding this comment.
nit: Since only source differs between this function and the other one, why one extract this into a common function to reduce code duplication?
|
Do we need to upgrade the libraries from Snyk? @HrikB @shahthepro |
We could do that, we also have dependabot on this repo that has some PR with the upgrades. However, we need to test it out to make sure it doesn't break anything else. Would be better off doing it in a different PR |
No description provided.