v8.1.1-rc.8 Testnet Release#4017
Merged
Mihajlo-Pavlovic merged 18 commits intov6/release/testnetfrom Jul 25, 2025
Merged
Conversation
…or-tx Bump gas price on nonce issue
…ber-issue Remove unneeded toNumber
…update Fix setCompletedAndFinalizedRandomSamplingChallengeRecord parameters
…sk-query Add ASK timeout to blazgraph query
v8.1.1-rc.8
| } | ||
|
|
||
| console.timeEnd(`BatchGetCommand [NETWORK]: ${operationId} ${uals.length}`); | ||
|
|
There was a problem hiding this comment.
Bug: Unintended Debugging Logs in Production Code
Unconditional console.time() and console.timeEnd() debugging statements were accidentally committed to production code in v1-0-0-handle-batch-get-request-command.js and batch-get-command.js. These performance timing logs will clutter console output in production environments and should be removed.
Locations (3)
| result[ual] = results[index]; | ||
| } | ||
|
|
||
| endTimer(totalLabel); |
There was a problem hiding this comment.
Bug: Remove Debugging Code from Production
Debugging console.time() and console.timeEnd() calls, which provide conditional performance logging based on operationId, were accidentally committed and should be removed from production code.
Locations (1)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.