Skip to content

chore: remove dead markdown extractor now field#128

Merged
Jurij89 merged 4 commits intotest/devnet-e2e-sections-18-24from
fix/issue-124-remove-dead-extractor-now
Apr 12, 2026
Merged

chore: remove dead markdown extractor now field#128
Jurij89 merged 4 commits intotest/devnet-e2e-sections-18-24from
fix/issue-124-remove-dead-extractor-now

Conversation

@Jurij89
Copy link
Copy Markdown
Contributor

@Jurij89 Jurij89 commented Apr 12, 2026

Summary

  • remove the dead MarkdownExtractInput.now field from the exported extractor input type
  • remove the stale FIXED_NOW / now: FIXED_NOW test-only usage from packages/cli/test/extraction-markdown.test.ts
  • keep the reviewed test-file cleanup from this PR: restored UTF-8 markdown fixture content and ASCII-only suite/comment labels where mojibake had appeared

Verification

  • rg -n "FIXED_NOW|\bnow:\s*|\bnow\?: Date\b|input\.now\b" packages/cli/src/extraction packages/cli/test/extraction-markdown.test.ts
  • pnpm exec vitest run test/extraction-markdown.test.ts

Docs

  • No separate dkgv10-spec PR needed. This is internal extractor cleanup, not a protocol or API-spec change.

Comment thread packages/cli/src/extraction/markdown-extractor.ts
Comment thread packages/cli/test/extraction-markdown.test.ts Outdated
Comment thread packages/cli/test/extraction-markdown.test.ts Outdated
Comment thread packages/cli/src/extraction/markdown-extractor.ts Outdated
Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codex review completed — no issues found.

Comment thread packages/cli/src/extraction/markdown-extractor.ts
@Jurij89 Jurij89 merged commit 0f21ab8 into test/devnet-e2e-sections-18-24 Apr 12, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant