Skip to content

fix(build): include node ui in root build#412

Merged
Jurij89 merged 3 commits intomainfrom
codex/fix-root-build-node-ui
May 5, 2026
Merged

fix(build): include node ui in root build#412
Jurij89 merged 3 commits intomainfrom
codex/fix-root-build-node-ui

Conversation

@Jurij89
Copy link
Copy Markdown
Contributor

@Jurij89 Jurij89 commented May 5, 2026

Summary

  • Restores repo-root pnpm run build (pnpm build shorthand) as the full developer/release build: no-argument builds run the workspace package build and then the filtered Node UI Vite build:ui task.
  • Preserves the previous Turbo passthrough contract for pnpm run build -- ...; forwarded args such as --dry=json and --filter=... go directly to turbo build.
  • Adds build:packages as the CI fast path that skips packages/node-ui/dist-ui/ while still running the existing package build graph, including any package-local Vite builds that are part of package output.
  • Removes duplicate Node UI Vite build steps from release/publish workflows and refreshes nearby docs so local package and repo-root build commands are clear.

Related

  • Regression introduced by PR Tests/improve #227 / commit 58c64b01, which split the Node UI Vite output out of the shared package build but left repo-root pnpm run build (pnpm build shorthand) without packages/node-ui/dist-ui/.

Files changed

File What
package.json, scripts/build.mjs Makes no-arg pnpm run build include the Node UI Vite bundle while preserving Turbo arg passthrough for pnpm run build -- ....
.github/workflows/*.yml Points CI-only builds at build:packages and removes release/publish duplicate UI builds.
README.md, CONTRIBUTING.md, packages/node-ui/README.md Clarifies repo-root and package-local build commands.

Test plan

  • pnpm install --frozen-lockfile
  • node --check scripts/build.mjs
  • pnpm run build -- --dry=json --filter=@origintrail-official/dkg-core confirmed forwarded Turbo args schedule only @origintrail-official/dkg-core#build.
  • pnpm run build:packages -- --dry=json confirmed the CI fast path schedules the package build graph without @origintrail-official/dkg-node-ui#build:ui.
  • pnpm turbo run build:ui --filter=@origintrail-official/dkg-node-ui --dry=json confirmed the filtered UI graph schedules @origintrail-official/dkg-node-ui#build:ui after #build.
  • Cleared packages/node-ui/dist-ui, then pnpm run build succeeded and recreated packages/node-ui/dist-ui/index.html.
  • git diff --check passed with line-ending warnings only on this Windows checkout.

Comment thread package.json Outdated
Comment thread package.json
@Jurij89 Jurij89 merged commit 9e7fd38 into main May 5, 2026
35 checks passed
Comment thread scripts/build.mjs
}
}

if (forwardedArgs.length > 0) {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 Bug: this treats any forwarded Turbo arg as a signal to skip the Node UI bundle. That means commands like pnpm build -- --force, --summarize, or even --filter=@origintrail-official/dkg-node-ui now produce an incomplete build with no packages/node-ui/dist-ui, which is easy to miss in local/release automation. Please distinguish "package-only" filters from general Turbo flags, or forward the relevant args to the build:ui step as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants