fix(build): include node ui in root build#412
Merged
Conversation
8 tasks
| } | ||
| } | ||
|
|
||
| if (forwardedArgs.length > 0) { |
There was a problem hiding this comment.
🔴 Bug: this treats any forwarded Turbo arg as a signal to skip the Node UI bundle. That means commands like pnpm build -- --force, --summarize, or even --filter=@origintrail-official/dkg-node-ui now produce an incomplete build with no packages/node-ui/dist-ui, which is easy to miss in local/release automation. Please distinguish "package-only" filters from general Turbo flags, or forward the relevant args to the build:ui step as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pnpm run build(pnpm buildshorthand) as the full developer/release build: no-argument builds run the workspace package build and then the filtered Node UI Vitebuild:uitask.pnpm run build -- ...; forwarded args such as--dry=jsonand--filter=...go directly toturbo build.build:packagesas the CI fast path that skipspackages/node-ui/dist-ui/while still running the existing package build graph, including any package-local Vite builds that are part of package output.Related
58c64b01, which split the Node UI Vite output out of the shared package build but left repo-rootpnpm run build(pnpm buildshorthand) withoutpackages/node-ui/dist-ui/.Files changed
package.json,scripts/build.mjspnpm run buildinclude the Node UI Vite bundle while preserving Turbo arg passthrough forpnpm run build -- .....github/workflows/*.ymlbuild:packagesand removes release/publish duplicate UI builds.README.md,CONTRIBUTING.md,packages/node-ui/README.mdTest plan
pnpm install --frozen-lockfilenode --check scripts/build.mjspnpm run build -- --dry=json --filter=@origintrail-official/dkg-coreconfirmed forwarded Turbo args schedule only@origintrail-official/dkg-core#build.pnpm run build:packages -- --dry=jsonconfirmed the CI fast path schedules the package build graph without@origintrail-official/dkg-node-ui#build:ui.pnpm turbo run build:ui --filter=@origintrail-official/dkg-node-ui --dry=jsonconfirmed the filtered UI graph schedules@origintrail-official/dkg-node-ui#build:uiafter#build.packages/node-ui/dist-ui, thenpnpm run buildsucceeded and recreatedpackages/node-ui/dist-ui/index.html.git diff --checkpassed with line-ending warnings only on this Windows checkout.