fix(data): strip bogus snow depth from Open-Meteo fallback path#335
Merged
fix(data): strip bogus snow depth from Open-Meteo fallback path#335
Conversation
When NWS current conditions are unavailable, Open-Meteo is used as a full fallback — including its ERA5/GFS-modelled snow_depth which can be wildly wrong (e.g. 17 inches in flat southern NJ). Strip snow_depth before returning the fallback; only station observations are reliable. Fixes #334
Open-Meteo/VC snow_depth bleeds into US current conditions via the fusion engine's field-level merge even when NWS is available but returns null for snow depth. Strip model-sourced snow depth for US locations; international (ECMWF/Open-Meteo) is more reliable and kept.
…S trusted VC likely sources US snowDepth from SNODAS (gridded analysis), same unreliability as Open-Meteo ERA5/GFS. Only NWS snow depth accepted for US; international Open-Meteo (ECMWF) remains unaffected.
Five new tests covering: - Open-Meteo snow depth stripped for US (model/ERA5) - Visual Crossing snow depth stripped for US (likely SNODAS-derived) - NWS snow depth kept for US - Open-Meteo snow depth kept for international (ECMWF reliable) - pragma: no cover on async client fallback path (complex to mock)
Orinks
added a commit
that referenced
this pull request
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #334
When NWS current conditions are unavailable, Open-Meteo is used as a full fallback — including its ERA5/GFS-modelled
snow_depth, which can report wildly incorrect values (e.g. 17 inches on the ground in flat southern New Jersey in late February).Fix: Null out
snow_depth_inandsnow_depth_cmbefore returning the Open-Meteo fallback. Only real observation station data should populate snow depth.One-liner change in
_augment_current_with_openmeteo.