fix(weather): prefer provider-native time metadata#618
Merged
Conversation
Use Visual Crossing epoch fields for sun and moon times when available, and make Pirate Weather epoch parsing consistently honor the response timezone name instead of relying on fixed offsets. This reduces local reconstruction where the providers already return the necessary temporal metadata. Constraint: Preserve existing AccessiWeather models and display contracts. Rejected: Replace all unit conversions in this pass | models still store paired US/metric fields for display and fusion. Confidence: high Scope-risk: narrow Directive: Prefer provider-supplied timestamps/timezones before adding local reconstruction helpers. Tested: uv run pytest -q -n 0 --tb=short tests/test_visual_crossing_client.py tests/test_pirate_weather_client.py Tested: uv run ruff check src tests Tested: uv run pyright Not-tested: Live provider API calls
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tests
Notes