fix(notifications): filter SPS products by location zone#637
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TXZ105>107, and compare them with the location's forecast, fire, and county zone IDs.TXZ157) not receiving Dallas/Tarrant (TXZ118-119) SPS products while still keeping a localTXZ157SPS.Root cause
The active alert path honors the user's alert area setting, but the SPS product path reads the CWA-wide
/products/types/SPS/locations/{office}cache. For offices like FWD, that feed includes Dallas-area statements even when a Copperas Cove point has no active alert. Without a zone filter, those office products could be treated as informational SPS notifications for the current location.Validation
uv run pytest -q -n 0 --tb=short tests/test_split_notification_timers.py::TestSpsProductLocationFiltering tests/test_notification_sps_dedupe.pyruff format --check .uv run ruff check src testsuv run pyright