Skip to content

fix(a11y): add cancel close button to SiteManagerDialog#80

Merged
Orinks merged 1 commit intodevfrom
fix/PortkeyDrop-issue-34
Mar 5, 2026
Merged

fix(a11y): add cancel close button to SiteManagerDialog#80
Orinks merged 1 commit intodevfrom
fix/PortkeyDrop-issue-34

Conversation

@Orinks
Copy link
Copy Markdown
Owner

@Orinks Orinks commented Mar 4, 2026

Summary

  • add a dedicated Close button to SiteManagerDialog with id wx.ID_CANCEL
  • keep existing Escape key handling (EVT_CHAR_HOOK) for keyboard dismissal
  • extend dialog tests to verify close button exists and uses wx.ID_CANCEL

Testing

  • ruff check src/portkeydrop/dialogs/site_manager.py tests/test_site_manager_dialog.py
  • python -m pytest tests/test_site_manager_dialog.py -q
  • python -m pytest -q

Closes #34

@Orinks Orinks merged commit a4eee84 into dev Mar 5, 2026
6 checks passed
@Orinks Orinks deleted the fix/PortkeyDrop-issue-34 branch March 5, 2026 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant