fix LiquidPocketFeature inverted boolean name

[xiej2520]

The canBeExposedToAir boolean name is inverted, changed to avoidAir to match the 1.13.1 name.

exposableLavaPocket can either be exposed to air or enclosed, enclosedLavaPocket must be enclosed in netherrack on all sides. Does this fit the naming convention?

[SpaceWalkerRS]

Having taken a closer look, avoidAir seems wrong as well. If false, the lava must have 4 netherrack neighbors and 1 air; if true, it must have 5 air neighbors (the block above must always be netherrack). It seems to control whether the lava is fully exposed or not.

[xiej2520]

The check is !liquidPocketConfiguration.avoidAir && i == 4 && j == 1 || i == 5, OR is lower precedence so it's (!liquidPocketConfiguration.avoidAir && i == 4 && j == 1) || i == 5, so it can spawn surrounded by netherrack on 5 sides no matter what.

I checked by changing the exposableLavaPocket (avoidAir=false) to spawn water instead of lava, it also spawns enclosed.

[SpaceWalkerRS]

Oh the i == 5 is the netherrack count, not the air count... yeah the name makes sense then. It may be clearer with something like "always enclosed" but if you're happy with this I'll merge it as is.

[xiej2520]

Yep, sounds fine to me.