Conversation
Signed-off-by: Kevin Ullyott <ullyott.kevin@gmail.com>
Signed-off-by: Kevin Ullyott <ullyott.kevin@gmail.com>
Signed-off-by: Kevin Ullyott <ullyott.kevin@gmail.com>
Signed-off-by: Kevin Ullyott <ullyott.kevin@gmail.com>
Signed-off-by: Kevin Ullyott <ullyott.kevin@gmail.com>
Signed-off-by: Kevin Ullyott <ullyott.kevin@gmail.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new PHPStan rule CamelCaseParameterNameRule that enforces camelCase naming convention for function, method, and closure parameters. The implementation includes configurable options to allow underscore prefixes and consecutive uppercase letters, providing flexibility for different coding standards.
Key changes:
- Implementation of the core rule logic with regex-based parameter name validation
- Configuration system supporting two boolean options for naming flexibility
- Comprehensive test suite covering default behavior and all configuration combinations
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
src/Rules/CamelCaseParameterName/CamelCaseParameterNameRule.php |
Main rule implementation with regex pattern matching for camelCase validation |
src/Rules/CamelCaseParameterName/Config.php |
Configuration class for rule options |
config/extension.neon |
Service configuration and parameter schema definition |
tests/Rules/CamelCaseParameterName/Fixture/ExampleClass.php |
Test fixture with various parameter naming patterns |
| Multiple test files | Test cases for different configuration scenarios |
Signed-off-by: Kevin Ullyott <ullyott.kevin@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a new rule
CamelCaseParameterNameRuleto ensure that function, method, and closure parameters MUST be in camelCase.