Conversation
Signed-off-by: Kevin Ullyott <ullyott.kevin@gmail.com>
Signed-off-by: Kevin Ullyott <ullyott.kevin@gmail.com>
Signed-off-by: Kevin Ullyott <ullyott.kevin@gmail.com>
Signed-off-by: Kevin Ullyott <ullyott.kevin@gmail.com>
Signed-off-by: Kevin Ullyott <ullyott.kevin@gmail.com>
Signed-off-by: Kevin Ullyott <ullyott.kevin@gmail.com>
Signed-off-by: Kevin Ullyott <ullyott.kevin@gmail.com>
Signed-off-by: Kevin Ullyott <ullyott.kevin@gmail.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new SuperglobalsRule to detect unwanted usage of PHP superglobals, along with corresponding tests and documentation updates.
- Implements
SuperglobalsRuleto flag any direct use of PHP superglobals. - Adds test fixtures and a default-options test covering all superglobals.
- Provides documentation (
docs/Superglobals.md) and updates the mainREADME.mdto include the new rule.
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/Rules/Superglobals/config/configured_rule.neon | Registers the SuperglobalsRule for test scenarios |
| tests/Rules/Superglobals/Fixture/ExampleClass.php | Fixture demonstrating triggering and non-triggering cases |
| tests/Rules/Superglobals/DefaultOptionsTest.php | Verifies default behavior of the new rule |
| src/Rules/Superglobals/SuperglobalsRule.php | Implements the logic to detect superglobals usage |
| docs/Superglobals.md | Adds documentation for the Superglobals rule |
| README.md | Updates rules list to include Superglobals |
| .github/copilot-instructions.md | Adds Copilot instruction content (internal guidance) |
Comments suppressed due to low confidence (1)
.github/copilot-instructions.md:124
- The changes in this file introduce internal Copilot instructions that should not be committed to the repository. Please remove or revert these additions to avoid repository pollution.
## Documentation Standards
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Kevin Ullyott <ullyott.kevin@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
Superglobalsrule and set up documenation.