Skip to content

Superglobals and documentation#5

Merged
Orrison merged 11 commits intomainfrom
Superglobals
Jul 12, 2025
Merged

Superglobals and documentation#5
Orrison merged 11 commits intomainfrom
Superglobals

Conversation

@Orrison
Copy link
Owner

@Orrison Orrison commented Jul 12, 2025

Add Superglobals rule and set up documenation.

Orrison added 7 commits July 12, 2025 14:21
Signed-off-by: Kevin Ullyott <ullyott.kevin@gmail.com>
Signed-off-by: Kevin Ullyott <ullyott.kevin@gmail.com>
Signed-off-by: Kevin Ullyott <ullyott.kevin@gmail.com>
Signed-off-by: Kevin Ullyott <ullyott.kevin@gmail.com>
Signed-off-by: Kevin Ullyott <ullyott.kevin@gmail.com>
Signed-off-by: Kevin Ullyott <ullyott.kevin@gmail.com>
Signed-off-by: Kevin Ullyott <ullyott.kevin@gmail.com>
@Orrison Orrison requested a review from Copilot July 12, 2025 19:02

This comment was marked as outdated.

Orrison added 2 commits July 12, 2025 15:08
Signed-off-by: Kevin Ullyott <ullyott.kevin@gmail.com>
Signed-off-by: Kevin Ullyott <ullyott.kevin@gmail.com>
@Orrison Orrison requested a review from Copilot July 12, 2025 19:12
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a new SuperglobalsRule to detect unwanted usage of PHP superglobals, along with corresponding tests and documentation updates.

  • Implements SuperglobalsRule to flag any direct use of PHP superglobals.
  • Adds test fixtures and a default-options test covering all superglobals.
  • Provides documentation (docs/Superglobals.md) and updates the main README.md to include the new rule.

Reviewed Changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
tests/Rules/Superglobals/config/configured_rule.neon Registers the SuperglobalsRule for test scenarios
tests/Rules/Superglobals/Fixture/ExampleClass.php Fixture demonstrating triggering and non-triggering cases
tests/Rules/Superglobals/DefaultOptionsTest.php Verifies default behavior of the new rule
src/Rules/Superglobals/SuperglobalsRule.php Implements the logic to detect superglobals usage
docs/Superglobals.md Adds documentation for the Superglobals rule
README.md Updates rules list to include Superglobals
.github/copilot-instructions.md Adds Copilot instruction content (internal guidance)
Comments suppressed due to low confidence (1)

.github/copilot-instructions.md:124

  • The changes in this file introduce internal Copilot instructions that should not be committed to the repository. Please remove or revert these additions to avoid repository pollution.
## Documentation Standards

Orrison and others added 2 commits July 12, 2025 15:13
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Kevin Ullyott <ullyott.kevin@gmail.com>
@Orrison Orrison merged commit 5ef2e58 into main Jul 12, 2025
5 checks passed
@Orrison Orrison deleted the Superglobals branch July 12, 2025 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants