Conversation
Signed-off-by: Kevin Ullyott <ullyott.kevin@gmail.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refines the CamelCase variable name rule to properly allow single-letter variable names like $i by making the regex pattern more permissive and updating documentation and test fixtures to reflect this intended behavior.
Key Changes
- Updated regex pattern to make trailing camelCase groups optional, allowing single-letter variables
- Added documentation clarifying that single-letter variables are valid
- Enhanced test fixture with single-letter variable example
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/Rules/CamelCaseVariableName/CamelCaseVariableNameRule.php |
Modified regex pattern to make trailing groups optional for single-letter variable support |
docs/CamelCaseVariableName.md |
Added documentation example showing single-letter variables are valid |
tests/Rules/CamelCaseVariableName/Fixture/ExampleClass.php |
Added test case with single-letter variable assignment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes targeted improvements to the CamelCase variable name rule, clarifying documentation, adjusting the regex logic to be more permissive, and updating test fixtures to reflect the intended behavior. The main focus is ensuring that single-letter variable names are allowed, and the regex for variable name validation is updated accordingly.
Rule logic adjustment:
CamelCaseVariableNameRule.phpto make the trailing group optional, allowing single-letter variable names to pass the validation.Documentation update:
CamelCaseVariableName.mdto explicitly state that single-letter variables (e.g.,$i) are valid.Test fixture update:
ExampleClass.phpto demonstrate and test that such variables are allowed.Resolves #69