Conversation
…erface, trait, and enum names Signed-off-by: Kevin Ullyott <ullyott.kevin@gmail.com>
Closed
Contributor
There was a problem hiding this comment.
Pull Request Overview
Implements a new LongClassName rule to enforce maximum length limits on class, interface, trait, and enum names, addressing issue #22. The rule provides configurable options for maximum length and allows excluding specific prefixes/suffixes from length calculations.
- Adds the core LongClassName rule with flexible configuration options
- Implements comprehensive test coverage for all configuration scenarios
- Includes proper integration with the extension's configuration system
Reviewed Changes
Copilot reviewed 19 out of 19 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/Rules/LongClassName/LongClassNameRule.php | Main rule implementation that checks name lengths against configured limits |
| src/Rules/LongClassName/Config.php | Configuration class defining maximum length and prefix/suffix exclusions |
| config/extension.neon | Extension configuration with schema definition and service registration |
| tests/Rules/LongClassName/*.php | Comprehensive test suite covering default behavior and all configuration options |
| docs/LongClassName.md | Complete documentation with usage examples and configuration details |
| README.md | Updated to include the new rule in the available rules list |
| composer.json | Added autoload-dev section for test namespace |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Kevin Ullyott <ullyott.kevin@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the LongClassName rule to resolve #22