Prevents auto registration of NumberOfChildrenCollector if it is not needed#89
Merged
Prevents auto registration of NumberOfChildrenCollector if it is not needed#89
Conversation
…iles Signed-off-by: Kevin Ullyott <ullyott.kevin@gmail.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR stops auto-registering the NumberOfChildrenCollector and updates tests and docs to require explicit collector registration when using the NumberOfChildren rule.
- Remove collector service from the extension’s default services.
- Add explicit collector registration to NumberOfChildren test configs.
- Update documentation to instruct users to register the collector alongside the rule.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| config/extension.neon | Removes auto-registration of NumberOfChildrenCollector to avoid unnecessary overhead when the rule isn’t used. |
| tests/Rules/NumberOfChildren/config/default.neon | Adds explicit collector service registration for tests. |
| tests/Rules/NumberOfChildren/config/maximum-one.neon | Adds explicit collector service registration for tests. |
| tests/Rules/NumberOfChildren/config/maximum-two.neon | Adds explicit collector service registration for tests. |
| docs/NumberOfChildren.md | Updates usage docs to require registering the collector and clarifies the requirement. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Does not register
NumberOfChildrenCollectorif you do not need it.