Skip to content

RMET-4287 ::: Ability to Pass Custom Headers#48

Merged
andredestro merged 2 commits intodevelopmentfrom
feat/RMET-4287/custom-headers
Jul 18, 2025
Merged

RMET-4287 ::: Ability to Pass Custom Headers#48
andredestro merged 2 commits intodevelopmentfrom
feat/RMET-4287/custom-headers

Conversation

@andredestro
Copy link
Copy Markdown
Contributor

Description

This PR adds the ability to pass custom headers to the WebView.

Context

https://outsystemsrd.atlassian.net/browse/RMET-4287

Type of changes

  • Fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Refactor (cosmetic changes)
  • Breaking change (change that would cause existing functionality to not work as expected)

Platforms affected

  • Android
  • iOS
  • JavaScript

Tests

Screenshots (if appropriate)

Checklist

  • Pull request title follows the format RNMT-XXXX <title>
  • Code follows code style of this project
  • CHANGELOG.md file is correctly updated
  • Changes require an update to the documentation
    • Documentation has been updated accordingly

@andredestro andredestro self-assigned this Jul 17, 2025
@cssecautomation
Copy link
Copy Markdown

cssecautomation commented Jul 17, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

license/snyk check is complete. No issues have been found. (View Details)

code/snyk check is complete. No issues have been found. (View Details)

@andredestro andredestro marked this pull request as ready for review July 17, 2025 15:29
@andredestro andredestro requested review from a team, ItsChaceD, OS-pedrogustavobilro, OS-ruimoreiramendes, alexgerardojacinto and eric-horodyski and removed request for a team July 17, 2025 15:30
enableEdgeToEdge()
}

private fun getParametersFromIntentExtras(): Pair<String?, HashMap<String, String>?> {
Copy link
Copy Markdown
Collaborator

@alexgerardojacinto alexgerardojacinto Jul 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this function returns urlToOpen and customHeaders, shouldn't it also return options instead of assigning it to the global variable of the class?

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or, each field could be fetched from the intent using a separate function, instead of doing it all in the same one.

@andredestro andredestro force-pushed the feat/RMET-4287/custom-headers branch from 69450a9 to ff10069 Compare July 18, 2025 13:17
@andredestro andredestro merged commit e5a5d1b into development Jul 18, 2025
5 of 6 checks passed
@andredestro andredestro deleted the feat/RMET-4287/custom-headers branch July 18, 2025 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants