Skip to content

Conversation

@andredestro
Copy link
Contributor

Description

This PR adds SPM compatibility

Context

https://outsystemsrd.atlassian.net/browse/RMET-4316

Type of changes

  • Fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Refactor (cosmetic changes)
  • Breaking change (change that would cause existing functionality not to work as expected)

Tests

Screenshots (if appropriate)

Checklist

  • Pull request title follows the format RNMT-XXXX <title>
  • Code follows the code style of this project
  • CHANGELOG.md file is correctly updated
  • Changes require an update to the documentation
    • Documentation has been updated accordingly

@andredestro andredestro self-assigned this Sep 4, 2025
@andredestro andredestro requested a review from a team as a code owner September 4, 2025 17:21
@alexgerardojacinto
Copy link

The Unit Tests check seems to have failed because it couldn't find Xcode 🤔

@OS-pedrogustavobilro
Copy link
Contributor

The Unit Tests check seems to have failed because it couldn't find Xcode 🤔

It's because macos-latest (which is now 15) does not come bundled with most XCode versions (like 15.0), nor iOS simulator runtime. We have future work to address this. For now I've been setting github actions to use macos-14 image, if you'd like to change that @andredestro

@OS-pedrogustavobilro OS-pedrogustavobilro linked an issue Sep 5, 2025 that may be closed by this pull request
@andredestro andredestro force-pushed the feat/RMET-4316/spm-compatibility branch from 5a1869b to e902089 Compare September 5, 2025 08:21
@cssecautomation
Copy link

cssecautomation commented Sep 5, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

license/snyk check is complete. No issues have been found. (View Details)

code/snyk check is complete. No issues have been found. (View Details)

@andredestro andredestro force-pushed the feat/RMET-4316/spm-compatibility branch 2 times, most recently from 1d0f1e3 to 6fb98a0 Compare September 5, 2025 08:26
@OS-pedrogustavobilro
Copy link
Contributor

OS-pedrogustavobilro commented Sep 5, 2025

Unit tests seem to be broken per the failing CI logs, unsure if it's due to this PR 🤔

@andredestro andredestro force-pushed the feat/RMET-4316/spm-compatibility branch from 6fb98a0 to 3f8cbad Compare September 5, 2025 08:36
@andredestro
Copy link
Contributor Author

Unit tests seem to be broken per the failing CI logs, unsure if it's due to this PR 🤔

This test was broken in the build time 😞

@andredestro andredestro force-pushed the feat/RMET-4316/spm-compatibility branch from 3f8cbad to 8be3623 Compare September 5, 2025 08:41
@andredestro
Copy link
Contributor Author

The Unit Tests check seems to have failed because it couldn't find Xcode 🤔

It's because macos-latest (which is now 15) does not come bundled with most XCode versions (like 15.0), nor iOS simulator runtime. We have future work to address this. For now I've been setting github actions to use macos-14 image, if you'd like to change that @andredestro

Changed to use the macos-14 image.
Once we decide on this PR, we can bring the GitHub Actions setup to this project.
In the template, it seems to be working with macos-15.

@andredestro
Copy link
Contributor Author

The Unit Tests check seems to have failed because it couldn't find Xcode 🤔

It's because macos-latest (which is now 15) does not come bundled with most XCode versions (like 15.0), nor iOS simulator runtime. We have future work to address this. For now I've been setting github actions to use macos-14 image, if you'd like to change that @andredestro

Changed to use the macos-14 image. Once we decide on this PR, we can bring the GitHub Actions setup to this project. In the template, it seems to be working with macos-15.

Example of this pull request, but with the changes on the workflows: #32

@andredestro andredestro merged commit 23d44f4 into main Sep 5, 2025
4 of 5 checks passed
@andredestro andredestro deleted the feat/RMET-4316/spm-compatibility branch September 5, 2025 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add spm support

6 participants