Fix issues with odd filenames in repo and add Service Studio and Integration Studio as separate installers #138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes due to the split of Development Environment installer into separate Service Studio and Integration Studio ones.
…ersion[]] Some files in the repository have names ending in ..exe or have version numbers not following major.minor.build.revision causing variable assignment with [System.Version[]] to fail Removing extension and whatever is after the correct version numbering with regex.
sergiomiranda-outsystems
requested review from
luisalourenco and
pedro132
as code owners
pedro132
reviewed
Apr 23, 2025
Collaborator
pedro132
left a comment
pedro132
left a comment
There was a problem hiding this comment.
Hi Sérgio, thanks for opening this PR! Code looks good, I've just left a comment about the implemented automatic tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issues with names and version numbers incompatible with [System.Version[]]
(Fixes #105)
Implement changes due to split of Development Environment installer to add Service Studio and Integration Studio as separate installers.