Fix issues of Publish-OSPlatformSolution with two step publishing #140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergiomiranda-outsystems
requested review from
luisalourenco and
pedro132
as code owners
luisalourenco
previously approved these changes
Jun 24, 2025
pedro132
requested changes
Jul 7, 2025
Collaborator
pedro132
left a comment
pedro132
left a comment
There was a problem hiding this comment.
I've had some trouble to setup this to test it locally, sorry. Meanwhile I noticed that the parameter names in the documentation don't align with what's in the code
src/Outsystems.SetupTools/Functions/Publish-OSPlatformSolution.ps1
Outdated
Show resolved
Hide resolved
src/Outsystems.SetupTools/Functions/Publish-OSPlatformSolution.ps1
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Hi @pedro132 .Thank you for reviewing this, you are right about the parameter name, already fix it. |
pedro132
approved these changes
Jul 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #86 and improves handling of two step solution publishing