RMET-4021 ::: Fix readAsArrayBuffer on Android >= 13 #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For media files, the permission request is only needed for Android 12 and below, will not be granted above Android 12 even with requestLegacyExternalStorage = true. References: https://outsystemsrd.atlassian.net/browse/RMET-4021
OS-pedrogustavobilro
requested review from
ItsChaceD,
OS-martacarlos,
OS-ricardomoreirasilva,
alexgerardojacinto and
eric-horodyski
and removed request for
a team
OS-ricardomoreirasilva
approved these changes
Jan 24, 2025
OS-martacarlos
approved these changes
Jan 27, 2025
alexgerardojacinto
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms affected
Android
What does this PR do?
Fixes
readAsArrayBufferwhen reading files from external storage (e.g. videos recorded from Camera Plugin with saveToGallery=true).Affects only Android versions >= 13, because the issue was related to requesting READ_EXTERNAL_STORAGE, which shouldn't be required for media files, and READ_EXTERNAL_STORAGE is never granted for apps above Android 12.
Also fixed another issue where local files would only be read if file:// was in the uri.
References: https://outsystemsrd.atlassian.net/browse/RMET-4021
What testing has been done on this change?