Skip to content

RMET-527 - iPad dismiss modal ImagePicker clicking outside issue fix#15

Merged
andregrillo merged 1 commit intooutsystemsfrom
fix/RMET-527-iPad-dismiss-modal-issue
Feb 3, 2021
Merged

RMET-527 - iPad dismiss modal ImagePicker clicking outside issue fix#15
andregrillo merged 1 commit intooutsystemsfrom
fix/RMET-527-iPad-dismiss-modal-issue

Conversation

@andregrillo
Copy link
Copy Markdown

@andregrillo andregrillo commented Feb 3, 2021

Description

Added a UIGestureRecognizer to detect clicks outside the UIImagePickerController

Context

Closes:
https://outsystemsrd.atlassian.net/browse/RMET-527

Type of changes

  • Fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Refactor (cosmetic changes)
  • Breaking change (change that would cause existing functionality to not work as expected)

Platforms affected

  • Android
  • iOS
  • JavaScript

Tests

Screenshots (if appropriate)

Checklist

  • Pull request title follows the format RNMT-XXXX <title>
  • Code follows code style of this project
  • CHANGELOG.md file is correctly updated
  • Changes require an update to the documentation
  • Documentation has been updated accordingly

Copy link
Copy Markdown

@vmfo22 vmfo22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this gesture have an impact in other use cases?

@andregrillo
Copy link
Copy Markdown
Author

Can this gesture have an impact in other use cases?

The UIGestureRecognizer is removed from the view as soon as the UIImagePicker is dismissed.
So, no, I don't think so.

@andregrillo andregrillo merged commit a3cffd9 into outsystems Feb 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants