Skip to content

ROU-11865: Spike for supporting the new Routes API#205

Merged
rugoncalves merged 12 commits into
ROU-12040from
ROU-11865-routesAPI
Jul 18, 2025
Merged

ROU-11865: Spike for supporting the new Routes API#205
rugoncalves merged 12 commits into
ROU-12040from
ROU-11865-routesAPI

Conversation

@rugoncalves
Copy link
Copy Markdown
Contributor

This PR is for adding support for the new Google Maps Routes API, as the current one being used is marked as Legacy.

What was happening

  • Google marked a the Directions API as Legacy. This means that new projects cannot use it, while the existing ones will continue to work.

What was done

  • Imported a new library
  • Created a Types file, as the current types library we use, is not updated
  • Consumed directly the new REST API
  • Created a route renderer, that mimics the style made by the DirectionsRenderer

Checklist

  • tested locally
  • documented the code
  • clean all warnings and errors of eslint
  • requires changes in OutSystems (if so, provide a module with changes)
  • requires new sample page in OutSystems (if so, provide a module with changes)

@rugoncalves rugoncalves added the do not merge This pull request should not be merged even if checks pass label Jun 16, 2025
@cssecautomation
Copy link
Copy Markdown

cssecautomation commented Jun 16, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

license/snyk check is complete. No issues have been found. (View Details)

code/snyk check is complete. No issues have been found. (View Details)

Comment thread src/Providers/Maps/Google/Features/Directions.ts Outdated
rugoncalves and others added 2 commits June 17, 2025 10:37
Co-authored-by: Marta Carlos <101343976+OS-martacarlos@users.noreply.github.com>
Comment thread src/Providers/Maps/Google/Features/Directions.ts Outdated
Comment thread src/Providers/Maps/Google/Features/Directions.ts
@sonarqubecloud
Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot

See analysis details on SonarQube Cloud

@rugoncalves rugoncalves changed the base branch from dev to ROU-12040 July 18, 2025 14:11
@rugoncalves rugoncalves changed the title ROU-11865: Supporting the new Routes API ROU-11865: Spike for supporting the new Routes API Jul 18, 2025
@rugoncalves rugoncalves marked this pull request as ready for review July 18, 2025 14:11
@rugoncalves rugoncalves requested a review from a team as a code owner July 18, 2025 14:11
@rugoncalves rugoncalves merged commit 25c4a9c into ROU-12040 Jul 18, 2025
8 of 12 checks passed
@rugoncalves rugoncalves deleted the ROU-11865-routesAPI branch July 18, 2025 14:12
rugoncalves added a commit that referenced this pull request Jul 21, 2025
* ROU-11865: Spike for supporting the new Routes API (#205)

* Adding new types of google maps

* Adding new helper method

* Adding new constants

* Adding new library

* Adding new type checker method

* Simplifying the code with new helper methods

* Adding new class to render Routes

* Changing directions to use new API

* Creating helper function

Co-authored-by: Marta Carlos <101343976+OS-martacarlos@users.noreply.github.com>

* Fixing directions

* Update Directions.ts

* Centering the map

---------

Co-authored-by: Marta Carlos <101343976+OS-martacarlos@users.noreply.github.com>

* Adding comments

* Fixing regex

* Adding new types for the new route API

* Transform coordinates to new type

* Storing developer sent way points to show on route

* Storing route markers

* Building route with intermediate points

* Move file to location

* Rename file

* Renaming class

* Removing unnecessary code

* Improving the security of the regex

---------

Co-authored-by: Marta Carlos <101343976+OS-martacarlos@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do not merge This pull request should not be merged even if checks pass

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants