Conversation
rugoncalves
previously approved these changes
Sep 22, 2021
Contributor
rugoncalves
left a comment
There was a problem hiding this comment.
Just some minor comments! Good Job!
glundgren93
reviewed
Sep 22, 2021
glundgren93
approved these changes
Sep 22, 2021
rugoncalves
approved these changes
Sep 22, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is for RGRIDT-883: [Maps] Drawing Tools - Polyline Block
What was happening
What was done
Tests:
2. Toggle Off the "Show/Hide Tool"
Expected: The drawPolyline block should not appear on the DrawingTools
2.Toggle Off the "Show/Hide Tool"
3.Toggle On the "Show/Hide Tool"
Expected: The drawPolyline block should appear on the DrawingTools
2. Select the DrawPolyline tool on the drawing tools (hover the map)
3. Draw a Polyline on the Map
Expected: A new polyline should appear on the Map with the color "Red"
2. Select the DrawPolyline tool on the drawing tools (hover the map)
3. Draw a Polyline on the Map
Expected: A new polyline should appear on the Map with the color "Black" and opacity 0.5
2. Select the DrawPolyline tool on the drawing tools (hover the map)
3. Draw a Polyline on the Map
Expected: A new polyline should appear on the Map with a weight of 20
Screenshots
Checklist