Skip to content

Improve architecture#37

Merged
joselrio merged 3 commits intodevfrom
Improve-architecture
Aug 31, 2021
Merged

Improve architecture#37
joselrio merged 3 commits intodevfrom
Improve-architecture

Conversation

@joselrio
Copy link
Copy Markdown
Contributor

This PR is to improve the way to deal with Accessibility attribute names and values. During this change I added some changes to improve the coherency across code.

What was done

  • Create a new constant with all the used accessibility attributes until now;
  • Sort alphabetically the Global Enum to improve coherency;
  • Match comments names in pattern;

Checklist

  • tested locally
  • documented the code
  • clean all warnings and errors of eslint
  • requires changes in OutSystems (if so, provide a module with changes)
  • requires new sample page in OutSystems (if so, provide a module with changes)

@joselrio joselrio merged commit cf84cfa into dev Aug 31, 2021
@joselrio joselrio deleted the Improve-architecture branch August 31, 2021 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants