fix: propagate error message in diagnostics for resolver failures#77
Merged
mechanik-daniel merged 2 commits intoOutburn-IL:mainfrom Apr 26, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves error handling and diagnostics reporting, specifically ensuring that error messages are properly preserved and tested when diagnostics are collected and reported.
Diagnostics handling improvements:
pushfunction insrc/utils/diagnostics.jsto ensure that if anErrorobject is passed (or an object with a stringmessageproperty), its message is explicitly copied to the diagnostics entry. This helps preserve the error message for later reporting.Testing enhancements:
test/use-fhir-server.test.jsto verify that the populated error message is preserved in the diagnostics when a resolver failure occurs in$useFhirServer, ensuring accurate error reporting in verbose evaluation.