raidboss: fix enuo-ex Gaze of the Void trigger#1044
Merged
Conversation
github-actions
Bot
added
raidboss
Collaborator
|
The original code was assuming that light and darkness appear as a pair... |
valarnin
approved these changes
May 3, 2026
Collaborator
valarnin
left a comment
valarnin
left a comment
There was a problem hiding this comment.
The logic bug in the original implementation was that the trimmedOrbs array was being re-indexed after each set of orbs was pulled out, rather than leaving the orb in the array and marking it as used somehow.
I only have tank and healer geared to do extreme, so those were the only two I tested in-game with... coincidentally the only two that weren't impacted by the logic bug.
This is definitely a more elegant solution though.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For a possible orb sequence LDLLDDLD:
0=L1 1=D1 2=L2 3=L3 4=D2 5=D3 6=D4 7=L4 (index=color+order)after 2 passes, it became:
3=L3 5=D3 6=D4 7=L4index of
lightis0, adds4became4, but its actual index is3,so the original logic couldn't work correctly.