Skip to content

raidboss: Windurst Third Walk timelines#1056

Merged
JLGarber merged 10 commits into
OverlayPlugin:mainfrom
JLGarber:windurst-third-walk-timelines
Jun 13, 2026
Merged

raidboss: Windurst Third Walk timelines#1056
JLGarber merged 10 commits into
OverlayPlugin:mainfrom
JLGarber:windurst-third-walk-timelines

Conversation

@JLGarber

Copy link
Copy Markdown
Collaborator

Tested in-game and against some random FFLogs reports. Triggers and Oopsy will be in a separate PR because they look moderately complex right now, and I'd like to get timeline support in place rather than delay it.

I'm confident the timings for things match up, but I would ask reviewers to specifically focus in on name lengths and potential superfluous syncs. There were a lot of choices about whether to sync more closely to castbars or to visuals, and in the end I typically chose to sync to castbar ends if it ended up being less than a second between castbar and mechanic resolution. Please let me know whether anything feels off in-game or in-emulator and I'll look at adjusting it.

@github-actions github-actions Bot added raidboss /ui/raidboss module needs-review Awaiting review labels May 14, 2026
@jacob-keller

Copy link
Copy Markdown

Nice! Unfortunately I cleared AR3 before I saw this. I'll test it again later this week hopefully.

Comment thread ui/raidboss/data/07-dt/alliance/windurst-third-walk.txt Outdated
@github-actions github-actions Bot removed the needs-review Awaiting review label Jun 12, 2026
@github-actions github-actions Bot added the needs-review Awaiting review label Jun 12, 2026
@Bing-su

Bing-su commented Jun 13, 2026

Copy link
Copy Markdown
Collaborator

I've tested it, and it looks ready to be merged.

@github-actions github-actions Bot removed the needs-review Awaiting review label Jun 13, 2026
@JLGarber

Copy link
Copy Markdown
Collaborator Author

Thanks much!

@JLGarber JLGarber merged commit 607655a into OverlayPlugin:main Jun 13, 2026
11 checks passed
github-actions Bot pushed a commit that referenced this pull request Jun 13, 2026
Tested in-game and against some random FFLogs reports. Triggers and
Oopsy will be in a separate PR because they look moderately complex
right now, and I'd like to get timeline support in place rather than
delay it.

I'm confident the timings for things match up, but I would ask reviewers
to specifically focus in on name lengths and potential superfluous
syncs. There were a lot of choices about whether to sync more closely to
castbars or to visuals, and in the end I typically chose to sync to
castbar ends if it ended up being less than a second between castbar and
mechanic resolution. Please let me know whether anything feels off
in-game or in-emulator and I'll look at adjusting it.

---------

Co-authored-by: Dowon <ks2515@naver.com> 607655a
github-actions Bot pushed a commit that referenced this pull request Jun 13, 2026
Tested in-game and against some random FFLogs reports. Triggers and
Oopsy will be in a separate PR because they look moderately complex
right now, and I'd like to get timeline support in place rather than
delay it.

I'm confident the timings for things match up, but I would ask reviewers
to specifically focus in on name lengths and potential superfluous
syncs. There were a lot of choices about whether to sync more closely to
castbars or to visuals, and in the end I typically chose to sync to
castbar ends if it ended up being less than a second between castbar and
mechanic resolution. Please let me know whether anything feels off
in-game or in-emulator and I'll look at adjusting it.

---------

Co-authored-by: Dowon <ks2515@naver.com> 607655a
github-actions Bot pushed a commit to Bing-su/cactbot that referenced this pull request Jun 13, 2026
…n#1056)

Tested in-game and against some random FFLogs reports. Triggers and
Oopsy will be in a separate PR because they look moderately complex
right now, and I'd like to get timeline support in place rather than
delay it.

I'm confident the timings for things match up, but I would ask reviewers
to specifically focus in on name lengths and potential superfluous
syncs. There were a lot of choices about whether to sync more closely to
castbars or to visuals, and in the end I typically chose to sync to
castbar ends if it ended up being less than a second between castbar and
mechanic resolution. Please let me know whether anything feels off
in-game or in-emulator and I'll look at adjusting it.

---------

Co-authored-by: Dowon <ks2515@naver.com> 607655a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

raidboss /ui/raidboss module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants