Skip to content

ci: bump actions/setup-node version to avoid regression#1100

Merged
valarnin merged 1 commit into
OverlayPlugin:mainfrom
xiashtra:node-premature-close-fix
Jul 1, 2026
Merged

ci: bump actions/setup-node version to avoid regression#1100
valarnin merged 1 commit into
OverlayPlugin:mainfrom
xiashtra:node-premature-close-fix

Conversation

@xiashtra

@xiashtra xiashtra commented Jul 1, 2026

Copy link
Copy Markdown
Collaborator

- Bumps `setup-node` to version >=24.18.0 to avoid a bug introduced in 24.17 (nodejs/#63989)
- `lint-pr-title` updated to use `checkout@v6` (missed in OverlayPlugin#1057)
@valarnin valarnin merged commit 762aa7b into OverlayPlugin:main Jul 1, 2026
11 of 13 checks passed
github-actions Bot pushed a commit that referenced this pull request Jul 1, 2026
…sion (#1100)

- Require `actions/setup-node` to use Node version >=24.18.0 to avoid a
bug introduced in 24.17 (nodejs/node#63989)
- `lint-pr-title` updated to use `actions/checkout@v6` (missed in #1057) 762aa7b
@xiashtra xiashtra deleted the node-premature-close-fix branch July 1, 2026 22:49
@Legends0

Legends0 commented Jul 2, 2026

Copy link
Copy Markdown
Collaborator

This might have broken the timeline test?

EDIT: Nevermind, problem went away after updating the PR branch.

This is what I saw:


> cactbot@0.37.3 test
> mocha

(node:3199) ExperimentalWarning: `--experimental-loader` may be removed in the future; instead use `register()`:
--import 'data:text/javascript,import { register } from "node:module"; import { pathToFileURL } from "node:url"; register("ts-node/esm", pathToFileURL("./"));'
(Use `node --trace-warnings ...` to show where the warning was created)
file:///home/runner/work/cactbot/cactbot/node_modules/yargs/yargs:3
const {applyExtends, cjsPlatformShim, Parser, Yargs, processArgv} = require('./build/index.cjs')
                                                                    ^

ReferenceError: require is not defined in ES module scope, you can use import instead
    at file:///home/runner/work/cactbot/cactbot/node_modules/yargs/yargs:3:69
    at ModuleJobSync.runSync (node:internal/modules/esm/module_job:551:37)
    at ModuleLoader.importSyncForRequire (node:internal/modules/esm/loader:346:47)
    at loadESMFromCJS (node:internal/modules/cjs/loader:1762:24)
    at Module._compile (node:internal/modules/cjs/loader:1926:5)
    at Object..js (node:internal/modules/cjs/loader:2084:10)
    at Module.load (node:internal/modules/cjs/loader:1666:32)
    at Module._load (node:internal/modules/cjs/loader:1447:12)
    at wrapModuleLoad (node:internal/modules/cjs/loader:260:19)
    at Module.require (node:internal/modules/cjs/loader:1689:12)

Node.js v26.4.0

@xiashtra

xiashtra commented Jul 2, 2026

Copy link
Copy Markdown
Collaborator Author

Node.js v26.4.0

This run pulled in Node 26, which may have breaking changes. I'm not sure why it grabbed this version, instead of the current LTS version of 24.18.0; setup-node is supposed to pull LTS versions unless directed otherwise. We should keep an eye out for this happening again.

@xiashtra xiashtra mentioned this pull request Jul 2, 2026
xiashtra added a commit that referenced this pull request Jul 2, 2026
Follow-up to #1100 : further restrict Node to the 24 LTS branch. Node 26
may have breaking changes (cf:
#1100 (comment)).
github-actions Bot pushed a commit that referenced this pull request Jul 2, 2026
Follow-up to #1100 : further restrict Node to the 24 LTS branch. Node 26
may have breaking changes (cf:
#1100 (comment)). 634d64c
github-actions Bot pushed a commit to ShadyWhite/cactbot that referenced this pull request Jul 2, 2026
Follow-up to OverlayPlugin#1100 : further restrict Node to the 24 LTS branch. Node 26
may have breaking changes (cf:
OverlayPlugin#1100 (comment)). 634d64c
github-actions Bot pushed a commit to ShadyWhite/cactbot that referenced this pull request Jul 2, 2026
Follow-up to OverlayPlugin#1100 : further restrict Node to the 24 LTS branch. Node 26
may have breaking changes (cf:
OverlayPlugin#1100 (comment)). 634d64c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants