Skip to content

Conversation

@wexxlee
Copy link
Collaborator

@wexxlee wexxlee commented Jun 26, 2024

No description provided.

@github-actions github-actions bot added the jobs /ui/jobs module label Jun 26, 2024
@wexxlee wexxlee enabled auto-merge (squash) June 26, 2024 15:16
@github-actions github-actions bot added the auto-merge PR will be auto-merged upon approving review label Jun 26, 2024
@valarnin
Copy link
Collaborator

Were the PCT/VIP job IDs (41, 42) verified, or just assumed?

@wexxlee
Copy link
Collaborator Author

wexxlee commented Jun 26, 2024

Were the PCT/VIP job IDs (41, 42) verified, or just assumed?

Verified in ClassJob.

Copy link
Collaborator

@MaikoTan MaikoTan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good, I add translations from the game files extracted

ko: '현자',
},
VPR: {
en: 'VPR',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
en: 'VPR',
en: 'VPR',
de: 'VPR',
fr: 'VPR',
ja: 'ヴァイパー',

en: 'VPR',
},
PCT: {
en: 'PCT',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
en: 'PCT',
en: 'PCT',
de: 'PKT',
fr: 'PIC',
ja: 'ピクトマンサー',

ko: '현자',
},
VPR: {
en: 'Viper',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
en: 'Viper',
en: 'Viper',
de: 'Viper',
fr: 'Rôdeur vipère',
ja: 'ヴァイパー',

en: 'Viper',
},
PCT: {
en: 'Pictomancer',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
en: 'Pictomancer',
en: 'Pictomancer',
de: 'Piktomant',
fr: 'Pictomancien',
ja: 'ピクトマンサー',

@wexxlee wexxlee merged commit 31bedcc into OverlayPlugin:main Jun 27, 2024
@github-actions github-actions bot removed the needs-review Awaiting review label Jun 27, 2024
@MaikoTan
Copy link
Collaborator

Oops, didn't notice that there is a merge queue.

wexxlee pushed a commit that referenced this pull request Jun 27, 2024
This is grabbed from #175 which I accidentally merged.
github-actions bot pushed a commit that referenced this pull request Jun 27, 2024
This is grabbed from #175 which I accidentally merged. dc973f0
github-actions bot referenced this pull request in ShadyWhite/cactbot Jun 27, 2024
This is grabbed from #175 which I accidentally merged. dc973f0
github-actions bot referenced this pull request in ShadyWhite/cactbot Jun 27, 2024
This is grabbed from #175 which I accidentally merged. dc973f0
@wexxlee wexxlee deleted the dt-jobenums branch June 27, 2024 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-merge PR will be auto-merged upon approving review jobs /ui/jobs module resources /resources

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants