raidboss: add msq level 91 timeline + triggers #239
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
raidboss
valarnin
reviewed
Jul 15, 2024
Collaborator
valarnin
left a comment
valarnin
left a comment
There was a problem hiding this comment.
I don't have time to actually test this right now. From a code standpoint it looks good in general, but I don't know if e.g. triggers feel like they're too spammy or if there are mechanics which would benefit from a trigger but are missing, so I'm not going to mark this as approved myself.
45 tasks
JLGarber
approved these changes
Jul 17, 2024
Collaborator
|
Looks good to me. I'll leave pushing the button to you in case your final read catches anything. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.