Skip to content

Conversation

@wexxlee
Copy link
Collaborator

@wexxlee wexxlee commented Jul 15, 2024

No description provided.

@github-actions github-actions bot added raidboss /ui/raidboss module oopsy /ui/oopsyraidsy module needs-review Awaiting review labels Jul 15, 2024
Copy link
Collaborator

@valarnin valarnin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have time to actually test this right now. From a code standpoint it looks good in general, but I don't know if e.g. triggers feel like they're too spammy or if there are mechanics which would benefit from a trigger but are missing, so I'm not going to mark this as approved myself.

@JLGarber
Copy link
Collaborator

Looks good to me. I'll leave pushing the button to you in case your final read catches anything.

@wexxlee wexxlee merged commit 4b24651 into OverlayPlugin:main Jul 18, 2024
@wexxlee wexxlee deleted the ihuykatumu branch July 18, 2024 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

oopsy /ui/oopsyraidsy module raidboss /ui/raidboss module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants