raidboss: Initial R1N #250
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
raidboss
JLGarber
approved these changes
Jul 17, 2024
Collaborator
JLGarber
left a comment
JLGarber
left a comment
There was a problem hiding this comment.
Looks good for a first pass. Thanks for getting the IDs in place, that will definitely make future work here at least a little easier.
Fix not detecting cards/intercards properly Change wording per review
Collaborator
Author
|
@JLGarber Fixed a few bugs I noticed after running this back a couple more times and actually watching the footage. Like the fact that the single braincell I have when on WAR means that left/right were actually inverse because tank PoV. I don't know if you want to re-review the changes. |
Collaborator
|
@valarnin looks good after those changes. I'll leave it to you to push the button just in case you find anything on your final reading. |
45 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's some TODOs left in the triggers file. I won't have time to look into them probably for the rest of the week at least, I'd rather get what I have up and available.