Skip to content

Conversation

@JLGarber
Copy link
Collaborator

Tested in-game.

This one should be relatively self-explanatory. TODOs are noted, but I'm happy to add others in if people think of them.

@github-actions github-actions bot added raidboss /ui/raidboss module oopsy /ui/oopsyraidsy module needs-review Awaiting review labels Jul 30, 2024
Copy link
Collaborator

@wexxlee wexxlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I didn't look at the to-do list before testing in-game, but came away with the same list, and certainly didn't notice any obvious omissions. Seems good to merge as is!

@wexxlee wexxlee merged commit bfc5ea4 into OverlayPlugin:main Aug 6, 2024
@github-actions github-actions bot removed the needs-review Awaiting review label Aug 6, 2024
github-actions bot pushed a commit that referenced this pull request Aug 6, 2024
Tested in-game.

This one should be relatively self-explanatory. TODOs are noted, but I'm
happy to add others in if people think of them. bfc5ea4
github-actions bot pushed a commit that referenced this pull request Aug 6, 2024
Tested in-game.

This one should be relatively self-explanatory. TODOs are noted, but I'm
happy to add others in if people think of them. bfc5ea4
@JLGarber JLGarber deleted the alexandria-basic-triggers branch August 25, 2024 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

oopsy /ui/oopsyraidsy module raidboss /ui/raidboss module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants