resources: Add the new (as of 7.0) 21/22 line fields #315
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
resources
Collaborator
|
Can we update the index table to match the lines? It's gotten quite out of sync, and is missing several entries. |
Author
Sounds good. Should I also change the first field to use the network log format instead of the parsed format? |
Collaborator
I'm not sure if we have an established rule for that, but in my opinion, it should follow the network lines. Others might want to chime in. |
xiashtra
approved these changes
Aug 4, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Aug 4, 2024
…315) Adds the new fields in the 7.0 version of the plugin. From a decompile, the new fields are: ``` combatant?.ID ?? 0, combatant?.Name, (byte)(int)packetMessage.effectDisplayType, packetMessage.actionId, packetMessage.actionAnimationId, packetMessage.animationLockTime, packetMessage.rotation ``` This should fix the issues that the log anonymizer has with the new fields. 56c5f38
45 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the new fields in the 7.0 version of the plugin.
From a decompile, the new fields are:
This should fix the issues that the log anonymizer has with the new fields.