Skip to content

Conversation

@YuzukiTsuru
Copy link
Collaborator

add R4S Witchgleam Self Tracker reminder

Simply show each witchgleam you got

@cactbotbot
Copy link
Collaborator

cactbotbot commented Aug 10, 2024

@YuzukiTsuru Thanks for your contribution! 🌵🚀

@github-actions github-actions bot added 💬cn raidboss /ui/raidboss module needs-review Awaiting review labels Aug 10, 2024
@YuzukiTsuru YuzukiTsuru changed the title raidboss:add R4S Witchgleam Self Tracker reminder raidboss: add R4S Witchgleam Self Tracker reminder Aug 10, 2024
@wexxlee
Copy link
Collaborator

wexxlee commented Aug 10, 2024

I think this would display an alert each time the user is hit, so if they are hit 3 times, that would be three back-to-back alerts. That feels a little noisy to me, especially since the hits occur immediately in succession (meaning stale alerts will continue to be displayed after a subsequent hit).

As an alternative, I'd suggest displaying only the total hit count (perhaps combined with 'Short' or 'Long') after all hits have happened, and I think just as an infoText (since the info doesn't require immediate action until the next mechanic, which has its own alert).

That still may be a little noisy for short-debuff players, who then will shortly thereafter get a Spread (x stacks) call -- but I think that's probably better than repeated alerts as the hits are happening.

(Feel free to disagree - just my $0.02.)

@wexxlee wexxlee removed the needs-review Awaiting review label Aug 10, 2024
@YuzukiTsuru
Copy link
Collaborator Author

I think this would display an alert each time the user is hit, so if they are hit 3 times, that would be three back-to-back alerts. That feels a little noisy to me, especially since the hits occur immediately in succession (meaning stale alerts will continue to be displayed after a subsequent hit).

As an alternative, I'd suggest displaying only the total hit count (perhaps combined with 'Short' or 'Long') after all hits have happened, and I think just as an infoText (since the info doesn't require immediate action until the next mechanic, which has its own alert).

That still may be a little noisy for short-debuff players, who then will shortly thereafter get a Spread (x stacks) call -- but I think that's probably better than repeated alerts as the hits are happening.

(Feel free to disagree - just my $0.02.)

Well, because it's easy to count hits that don't belong to you, it's designed to show you every hit. I'll change to infoText

@github-actions github-actions bot added the needs-review Awaiting review label Aug 11, 2024
@YuzukiTsuru YuzukiTsuru requested a review from wexxlee August 12, 2024 16:01
@wexxlee
Copy link
Collaborator

wexxlee commented Aug 17, 2024

Well, because it's easy to count hits that don't belong to you, it's designed to show you every hit. I'll change to infoText

Sorry, but I still think this is too noisy. For example:
image

Because these triggers stay active for four seconds, the infoText alerts simply stack on top of one another (scrolling the oldest off). With the default sound effect from each one, it also adds a lot of auditory clutter.

Since the actual hit count isn't needed until later, I'm not sure I see the rationale for firing an alert for each hit, as opposed to just displaying the total count once the hits are finished. And even that has potential to be unnecessarily noisy for short-debuff players, given this:
image

If you wanted to add a single infoText trigger that displays total hit count just for long debuff players once the hits have finished (e.g. 3 stacks (later)), I think that's fine though.

@wexxlee wexxlee removed the needs-review Awaiting review label Aug 17, 2024
@YuzukiTsuru
Copy link
Collaborator Author

That makes sense. Let me fix it

@github-actions github-actions bot added the needs-review Awaiting review label Aug 17, 2024
@github-actions github-actions bot removed the needs-review Awaiting review label Aug 17, 2024
YuzukiTsuru and others added 2 commits August 18, 2024 10:22
Co-authored-by: Wexx <86693821+wexxlee@users.noreply.github.com>
Co-authored-by: Wexx <86693821+wexxlee@users.noreply.github.com>
@github-actions github-actions bot added the needs-review Awaiting review label Aug 18, 2024
@github-actions github-actions bot removed the needs-review Awaiting review label Aug 18, 2024
@YuzukiTsuru YuzukiTsuru merged commit 6028f5c into OverlayPlugin:main Aug 18, 2024
github-actions bot pushed a commit that referenced this pull request Aug 18, 2024
)

add R4S Witchgleam Self Tracker reminder

Simply show each witchgleam you got

---------

Co-authored-by: Echoring <68432572+Echoring@users.noreply.github.com>
Co-authored-by: Wexx <86693821+wexxlee@users.noreply.github.com> 6028f5c
github-actions bot pushed a commit that referenced this pull request Aug 18, 2024
)

add R4S Witchgleam Self Tracker reminder

Simply show each witchgleam you got

---------

Co-authored-by: Echoring <68432572+Echoring@users.noreply.github.com>
Co-authored-by: Wexx <86693821+wexxlee@users.noreply.github.com> 6028f5c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

💬cn raidboss /ui/raidboss module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants