raidboss: r4s sunrise sabbath fix #366
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
raidboss
JLGarber
approved these changes
Aug 23, 2024
Collaborator
JLGarber
left a comment
JLGarber
left a comment
There was a problem hiding this comment.
I haven't been here yet myself since my static is taking it a little more slowly, but reading over it I think this is reasonable. If it breaks anything people will tell us quickly!
|
This seems reasonable. I can't test it yet because my group isn't at m4s. |
Collaborator
Author
|
Going to merge this for now given the need to version bump - if it doesn't resolve the issue, we can revisit. |
github-actions bot
pushed a commit
that referenced
this pull request
Aug 24, 2024
Fixes #361. The issue occurs because in some (but apparently not all) logs, the `ActorSetPos` and `ActorControlExtra` packets that are needed to identify the jumping clone and its position are ordered differently. Adding a short delay to `R4S Sunrise Sabbath Jumping Clone Collect 1` (to ensure the related `ActorSetPos` collector processes first) seems to fix the issue -- and because both collectors happen ~3s before the cannon color collect and subsequent callout trigger, this added delay doesn't delay the mechanic callout at all. This fixes the issue in the log @valarnin passed along, but additional in-game validation couldn't hurt. b5b484d
github-actions bot
pushed a commit
that referenced
this pull request
Aug 24, 2024
Fixes #361. The issue occurs because in some (but apparently not all) logs, the `ActorSetPos` and `ActorControlExtra` packets that are needed to identify the jumping clone and its position are ordered differently. Adding a short delay to `R4S Sunrise Sabbath Jumping Clone Collect 1` (to ensure the related `ActorSetPos` collector processes first) seems to fix the issue -- and because both collectors happen ~3s before the cannon color collect and subsequent callout trigger, this added delay doesn't delay the mechanic callout at all. This fixes the issue in the log @valarnin passed along, but additional in-game validation couldn't hurt. b5b484d
45 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #361.
The issue occurs because in some (but apparently not all) logs, the
ActorSetPosandActorControlExtrapackets that are needed to identify the jumping clone and its position are ordered differently. Adding a short delay toR4S Sunrise Sabbath Jumping Clone Collect 1(to ensure the relatedActorSetPoscollector processes first) seems to fix the issue -- and because both collectors happen ~3s before the cannon color collect and subsequent callout trigger, this added delay doesn't delay the mechanic callout at all.This fixes the issue in the log @valarnin passed along, but additional in-game validation couldn't hurt.